Adjustments to media browser resolve media for HA 2022.6#103
Merged
marcelveldt merged 12 commits intomainfrom May 31, 2022
Merged
Adjustments to media browser resolve media for HA 2022.6#103marcelveldt merged 12 commits intomainfrom
marcelveldt merged 12 commits intomainfrom
Conversation
balloob
reviewed
May 9, 2022
| ) | ||
| from homeassistant.config_entries import ConfigEntry | ||
| from homeassistant.core import HomeAssistant, callback | ||
| from homeassistant.helpers.service import async_get_current_entity |
There was a problem hiding this comment.
This will require a newer version of HA so you need to signal that to HACS. Maybe merge it when beta is out ?
Member
Author
There was a problem hiding this comment.
Yeah, leave it here as draft PR until new HA version is released which includes this new helper.
and use final implementation instead where we receive the entity id that requested the browse media
marcelveldt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the workaround to intercept the play_media request from the media browser now that an official solution has been implemented in HA core. We now receive the player id along with the browse media call so we can resolve the correct queue (= media player entity) directly.